Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent flashing "Verified" when sending number for verification #1075

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description

After submitting a phone number for verification, "Verified" was briefly, but incorrectly flashed before the correct "Pending" status. This PR fixes that.

PR Checklist

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@binh-dam-ibigroup binh-dam-ibigroup merged commit 47baf29 into dev Nov 29, 2023
9 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the fix-phone-verified-status-flashing branch November 29, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants